libct/cgroups/fs: simple optimization #2495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
Contributor
Author
Note this code was written and the measurements were done before merging #2446. Now the savings should be less dramatic, but still major. |
kolyshkin
changed the title
The result of cgroupv1.FindCgroupMountpoint() call (which is relatively expensive) is only used in case raw.innerPath is absolute, so it only makes sense to call it in that case. This drastically reduces the number of calls to FindCgroupMountpoint during container start (from 116 to 62 in my setup). Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
changed the title
mrunalp
approved these changes
Jul 6, 2020
Contributor
Author
|
@AkihiroSuda @cyphar PTAL (easy to review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is separated out from #2438 in order to make review easier
This adds a very simple and straightforward optimization.
Should be very easy to review.